[
https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544954#comment-14544954
]
Rakesh R commented on ZOOKEEPER-602:
------------------------------------
Thank you [~rgs] for the reviews.
bq. i think that should be LOG.error, given it's unhandled. what do you think?
Since {{ZooKeeperThread}} is not a critical thread, added the log message with
{{warn}} log level. Could you please look at {{ZooKeeperCriticalThread}}, it
has overridden {{#handleException}} and adding message with {{error}} log level
because the service will go down if the critical thread dies. If requires we
can do the changes, no issues.
> log all exceptions not caught by ZK threads
> -------------------------------------------
>
> Key: ZOOKEEPER-602
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client, server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-602-br3-4.patch, ZOOKEEPER-602.patch,
> ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch,
> ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch
>
>
> the java code should add a ThreadGroup exception handler that logs at ERROR
> level any uncaught exceptions thrown by Thread run methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
