> On May 13, 2015, 11:54 p.m., Raul Gutierrez Segales wrote:
> > src/java/main/org/apache/zookeeper/server/ContainerManager.java, line 79
> > <https://reviews.apache.org/r/33713/diff/5/?file=953158#file953158line79>
> >
> > this is a critical thread/task - how do we monitor its health like with
> > all the others (i.e.: https://issues.apache.org/jira/browse/ZOOKEEPER-1907)?
>
> Jordan Zimmerman wrote:
> I based ContainerManager on DatadirCleanupManager which doesn't have any
> monitoring. What do you suggest?
>
> Raul Gutierrez Segales wrote:
> Hmm, not sure — Rakesh, any thoughts?
Raul, Good catch!
Timer tasks stop to execute if in one of the tasks exception is thrown. One way
to handle this is by catching all the exceptions using try-catch(Throwable){//
add log message} and continue. IMO its not required to stop or shutdown the
ZooKeeper service if these tasks throws some exception. If we have such
critical case to stop the service, probably we can try something like
'ScheduledExecutorService'.
Reference :
http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/ScheduledExecutorService.html
- Rakesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/#review83684
-----------------------------------------------------------
On May 16, 2015, 4:18 p.m., Jordan Zimmerman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33713/
> -----------------------------------------------------------
>
> (Updated May 16, 2015, 4:18 p.m.)
>
>
> Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales.
>
>
> Bugs: ZOOKEEPER-2163
> https://issues.apache.org/jira/browse/ZOOKEEPER-2163
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Introduce new ZNode type: container
>
>
> Diffs
> -----
>
> src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca
> src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e
> src/java/main/org/apache/zookeeper/CreateMode.java d87f410
> src/java/main/org/apache/zookeeper/MultiTransactionRecord.java ea913b4
> src/java/main/org/apache/zookeeper/Op.java 97d3d7b
> src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331
> src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4
> src/java/main/org/apache/zookeeper/cli/CreateCommand.java c6de7c6
> src/java/main/org/apache/zookeeper/server/ContainerManager.java
> PRE-CREATION
> src/java/main/org/apache/zookeeper/server/DataNode.java b341a69
> src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
> 7e3c29f
> src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf
> src/java/main/org/apache/zookeeper/server/Request.java bed9b13
> src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d
> src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0
> src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
> cf0900b
>
> src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
> 4d061f4
> src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
> 6434d02
>
> src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
> 36a23ee
>
> src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
> a49319c
> src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e
> src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
> PRE-CREATION
> src/java/test/org/apache/zookeeper/test/CreateModeTest.java 9db01bb
> src/zookeeper.jute 709e935
>
> Diff: https://reviews.apache.org/r/33713/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Zimmerman
>
>
