-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/#review82962
-----------------------------------------------------------
Why do we still need:
```
+ class CreateContainerRequest {
+ ustring path;
+ buffer data;
+ vector<org.apache.zookeeper.data.ACL> acl;
+ }
```
? Can't we just use:
```
class CreateRequest {
ustring path;
buffer data;
vector<org.apache.zookeeper.data.ACL> acl;
int flags;
}
```
and set the corresponding bit in flags?
- Raul Gutierrez Segales
On May 8, 2015, 12:17 a.m., Jordan Zimmerman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33713/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:17 a.m.)
>
>
> Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales.
>
>
> Bugs: ZOOKEEPER-2163
> https://issues.apache.org/jira/browse/ZOOKEEPER-2163
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Introduce new ZNode type: container
>
>
> Diffs
> -----
>
> src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca
> src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e
> src/java/main/org/apache/zookeeper/CreateMode.java d87f410
> src/java/main/org/apache/zookeeper/MultiTransactionRecord.java ea913b4
> src/java/main/org/apache/zookeeper/Op.java 97d3d7b
> src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331
> src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4
> src/java/main/org/apache/zookeeper/cli/CreateCommand.java c6de7c6
> src/java/main/org/apache/zookeeper/server/ContainerManager.java
> PRE-CREATION
> src/java/main/org/apache/zookeeper/server/DataNode.java b341a69
> src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
> 7e3c29f
> src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf
> src/java/main/org/apache/zookeeper/server/Request.java bed9b13
> src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d
> src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0
> src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
> cf0900b
>
> src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
> 4d061f4
> src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
> 6434d02
>
> src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
> 36a23ee
>
> src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
> a49319c
> src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e
> src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
> PRE-CREATION
> src/java/test/org/apache/zookeeper/test/CreateModeTest.java 9db01bb
> src/zookeeper.jute 709e935
>
> Diff: https://reviews.apache.org/r/33713/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Zimmerman
>
>
