[
https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565115#comment-14565115
]
Hongchao Deng commented on ZOOKEEPER-2187:
------------------------------------------
+1, Thanks [~rgs]. I will commit this shortly.
> remove duplicated code between CreateRequest{,2}
> ------------------------------------------------
>
> Key: ZOOKEEPER-2187
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2187
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, java client, server
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Priority: Minor
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2187.patch
>
>
> To avoid cargo culting and reducing duplicated code we can merge most of
> CreateRequest & CreateRequest2 given that only the Response object is
> actually different.
> This will improve readability of the code plus make it less confusing for
> people adding new opcodes in the future (i.e.: copying a request definition
> vs reusing what's already there, etc.).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
