[ https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565931#comment-14565931 ]
Hudson commented on ZOOKEEPER-2187: ----------------------------------- FAILURE: Integrated in ZooKeeper-trunk #2707 (See [https://builds.apache.org/job/ZooKeeper-trunk/2707/]) ZOOKEEPER-2187: remove duplicated code between CreateRequest{,2} (Raul Gutierrez Segales via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1682521) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/src/zookeeper.c * /zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiTransactionRecord.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java * /zookeeper/trunk/src/zookeeper.jute > remove duplicated code between CreateRequest{,2} > ------------------------------------------------ > > Key: ZOOKEEPER-2187 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2187 > Project: ZooKeeper > Issue Type: Bug > Components: c client, java client, server > Reporter: Raul Gutierrez Segales > Assignee: Raul Gutierrez Segales > Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2187.patch > > > To avoid cargo culting and reducing duplicated code we can merge most of > CreateRequest & CreateRequest2 given that only the Response object is > actually different. > This will improve readability of the code plus make it less confusing for > people adding new opcodes in the future (i.e.: copying a request definition > vs reusing what's already there, etc.). -- This message was sent by Atlassian JIRA (v6.3.4#6332)