[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619516#comment-14619516
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1423:
---------------------------------------------------

Thanks [~eribeiro]! One last nit (though, a bit more than a nit since it's a 
legal thing ;-): the license header is missing in 
src/java/main/org/apache/zookeeper/server/command/DirsCommand.java. After that 
I am happy to merge it, +1.

Thanks!

> 4lw and jmx should expose the size of the datadir/datalogdir
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1423
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx
>    Affects Versions: 3.5.0
>            Reporter: Patrick Hunt
>            Assignee: Edward Ribeiro
>              Labels: newbie
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, 
> ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch, 
> ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the 
> datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It 
> would be good to expose these metrics through jmx/4lw such that monitoring 
> can be done on the size. Would key ppl in on whether cleanup was actually 
> running. In particular this could be monitored/alerted on by third party 
> systems (nagios, ganglia and the like).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to