[
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619862#comment-14619862
]
Hadoop QA commented on ZOOKEEPER-1423:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12744356/ZOOKEEPER-1423.8.patch
against trunk revision 1689571.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//console
This message is automatically generated.
> 4lw and jmx should expose the size of the datadir/datalogdir
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1423
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
> Affects Versions: 3.5.0
> Reporter: Patrick Hunt
> Assignee: Edward Ribeiro
> Labels: newbie
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch,
> ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch,
> ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.8.patch, ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the
> datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It
> would be good to expose these metrics through jmx/4lw such that monitoring
> can be done on the size. Would key ppl in on whether cleanup was actually
> running. In particular this could be monitored/alerted on by third party
> systems (nagios, ganglia and the like).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
