I you have time to check this release, and dont foresee that you'll have time to check the next rc as in depth, I'd go ahead and check this one. If the licensing issue is the only problem (it seems to be all that has been raised this vote), the all that needs to be fixed and checked in the next rc is the licensing, which is a quick check.
-Ivan On Sun, Jul 19, 2015 at 4:20 PM Flavio P JUNQUEIRA <f...@apache.org> wrote: > Please see the discussion here, Camille: > > https://issues.apache.org/jira/browse/ZOOKEEPER-2235 > > -Flavio > > > On Sun, Jul 19, 2015 at 2:44 PM, Camille Fournier <cami...@apache.org> > wrote: > > > I'm checking out the tag to do a check. Do we need to do anything with > > Ivan's -1? I don't want to spend time checking a release that can't move > > forward due to a -1. > > > > Thanks, > > C > > > > On Thu, Jul 16, 2015 at 8:56 AM, Flavio Junqueira < > > flavio.junque...@gmail.com> wrote: > > > > > That's a good observation. The description here about what NOTICE > should > > > contain: > > > > > > http://www.apache.org/dev/licensing-howto.html < > > > http://www.apache.org/dev/licensing-howto.html> > > > > > > says to be careful and not add unnecessarily. Having said that, the > jars > > > are under Apache 2.0, except these: > > > > > > - jline which has a license file under lib, I don't think we need to > add > > > it to the NOTICE file > > > - slf4j has an MIT license and the license says that the copyright > notice > > > and the permission notice need to be included. We need to copy the > > license > > > under lib just like we did for jline, but again I don't think we need > to > > > copy it over as per the description I cited above > > > - servlet-api needs an addition to NOTICE, see the discussion in > > > LUCENE-4431 > > > > > > If I haven't missed anything, we need to add two license files and make > > > one addition to NOTICE.txt. > > > > > > That's the longest release process ever in this project! > > > > > > -Flavio > > > > > > > On 16 Jul 2015, at 12:41, Ivan Kelly <iv...@apache.org> wrote: > > > > > > > > Hi Michi, > > > > > > > > -1 > > > > > > > > The tarball contains a bunch of jars(under lib), but there is no > > mention > > > of > > > > these in the NOTICE file. Perhaps phunt knows whether this is ok, but > > my > > > > understanding is that if you are distributing the binaries, you need > to > > > > mention them in the NOTICE. > > > > > > > > Apart from that the release looks good. I tested against midonet (my > > > > companies product), wrote a small test app, ran the tests. All looked > > > fine. > > > > > > > > -Ivan > > > > > > > > > > > > > > > > On Mon, Jul 13, 2015 at 8:15 PM Michi Mutsuzaki <mutsuz...@gmail.com > > > > > wrote: > > > > > > > >> We have received 2 binding +1s so far (Flavio, Michi). I'm extending > > > >> the voting period to give other PMCs some more time to vote. Please > > > >> vote by July 20th 2015, 23:59 UTC+0. > > > >> > > > >> Thanks! > > > >> --Michi > > > >> > > > >> > > > >> On Thu, Jul 9, 2015 at 11:44 PM, Rakesh R <rake...@huawei.com> > wrote: > > > >>> > > > >>> +1 > > > >>> > > > >>> - Built from source. > > > >>> - Ran unit tests and tested few shell cmds, JMX attributes, basic > > > >> watcher behaviors. > > > >>> > > > >>> Thanks Michi for making the release! > > > >>> > > > >>> Best Regards, > > > >>> Rakesh > > > >>> > > > >>> -----Original Message----- > > > >>> From: Raúl Gutiérrez Segalés [mailto:r...@itevenworks.net] > > > >>> Sent: 10 July 2015 11:42 > > > >>> To: dev@zookeeper.apache.org > > > >>> Subject: Re: [VOTE] Apache ZooKeeper release 3.5.1-alpha candidate > 3 > > > >>> > > > >>> +1 > > > >>> > > > >>> My testing was: > > > >>> * 3 participants + 2 observers using systemd-nspawn > > > >>> * triggered elections > > > >>> * ran some smoke tests with zk-shell along with more elections > > > >>> > > > >>> All looks good. Thanks Michi! > > > >>> > > > >>> > > > >>> -rgs > > > >>> > > > >>> > > > >>> On 9 July 2015 at 15:23, Hongchao Deng <fengjingc...@hotmail.com> > > > wrote: > > > >>> > > > >>>> +1.Ran unit test and some basic programs. It went pretty > > smooth.Thanks > > > >>>> Michi! > > > >>>> > > > >>>> - Hongchao Deng > > > >>>> > > > >>>>> Date: Thu, 9 Jul 2015 12:09:44 -0700 > > > >>>>> Subject: Re: [VOTE] Apache ZooKeeper release 3.5.1-alpha > candidate > > 3 > > > >>>>> From: mutsuz...@gmail.com > > > >>>>> To: dev@zookeeper.apache.org > > > >>>>> > > > >>>>> Just a reminder, the vote is closing in about two days, and we > > > >>>>> haven't received enough binding votes yet. Please vote when you > > get a > > > >> chance. > > > >>>>> Thanks! > > > >>>>> > > > >>>>> On Mon, Jul 6, 2015 at 10:58 PM, Michi Mutsuzaki > > > >>>>> <mutsuz...@gmail.com> > > > >>>> wrote: > > > >>>>>> +1 > > > >>>>>> > > > >>>>>> - Ran ant test on ubuntu. > > > >>>>>> - Compiled the c client on mac. > > > >>>>>> > > > >>>>>> On Mon, Jul 6, 2015 at 2:26 AM, Flavio Junqueira > > > >>>>>> <fpjunque...@yahoo.com.invalid> wrote: > > > >>>>>>> +1, I ran tests, checked license and notice files, ran release > > > >>>>>>> +audit > > > >>>> to make sure that rat had no issues to report. > > > >>>>>>> > > > >>>>>>> -Flavio > > > >>>>>>> > > > >>>>>>>> On 28 Jun 2015, at 08:47, Michi Mutsuzaki < > mutsuz...@gmail.com> > > > >>>> wrote: > > > >>>>>>>> > > > >>>>>>>> This is the fourth release candidate for 3.5.1-alpha. This > > > >>>>>>>> candidate fixes the c client compilation error on os x found > in > > > >>>>>>>> the previous candidate. The full release notes is available > at: > > > >>>>>>>> > > > >>>> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310 > > > >>>> 801&version=12326786 > > > >>>>>>>> > > > >>>>>>>> *** Please download, test and vote by July 11th 2015, 23:59 > > UTC+0. > > > >>>> *** > > > >>>>>>>> > > > >>>>>>>> Source files: > > > >>>>>>>> > > http://people.apache.org/~michim/zookeeper-3.5.1-alpha-candidate > > > >>>>>>>> -3/ > > > >>>>>>>> > > > >>>>>>>> Maven staging repo: > > > >>>>>>>> > > > >>>> > > > https://repository.apache.org/content/groups/staging/org/apache/zookee > > > >>>> per/zookeeper/3.5.1-alpha/ > > > >>>>>>>> > > > >>>>>>>> The tag to be voted upon: > > > >>>>>>>> > > https://svn.apache.org/repos/asf/zookeeper/tags/release-3.5.1-rc > > > >>>>>>>> 3/ > > > >>>>>>>> > > > >>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the > > > >> release: > > > >>>>>>>> http://www.apache.org/dist/zookeeper/KEYS > > > >>>>>>>> > > > >>>>>>>> Should we release this candidate? > > > >>>>>>> > > > >>>> > > > >>>> > > > >> > > > > > > > > >
