[
https://issues.apache.org/jira/browse/ZOOKEEPER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056912#comment-15056912
]
Chris Nauroth commented on ZOOKEEPER-412:
-----------------------------------------
[~suda], thank you for the patch. Here are a few small comments.
{code}
<target name="checkstyle" depends="ivy-retrieve-test" description="Run
optional third-party tool targets">
<taskdef
resource="com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties"
uri="antlib:com.puppycrawl.tools.checkstyle.ant">
<classpath path="${ivy.test.lib}/checkstyle-6.13.jar"/>
{code}
# The description isn't accurate. I see this was taken from the existing code,
but could you take the opportunity to change it to something like "Run
Checkstyle coding standard checks"?
# It looks like there are tab characters in the {{<classpath>}} lines. Would
you please switch to spaces?
# Do you think it makes sense to use a wildcard to put all of {{ivy.test.lib}}
on the classpath? Would this be more resilient to change if the dependencies
ever change in the future?
> checkstyle target fails trunk build
> -----------------------------------
>
> Key: ZOOKEEPER-412
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-412
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Giridharan Kesavan
> Assignee: Akihiro Suda
> Attachments: ZOOKEEPER-412-v2.patch, ZOOKEEPER-412.patch,
> checkstyle-errors-trunk-20151211.html.gz
>
>
> BUILD FAILED
> /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:865:
> Unable to create a Checker: cannot initialize module PackageHtml - Unable to
> instantiate PackageHtml
> Tnx!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
