----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119280 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 217) <https://reviews.apache.org/r/25160/#comment180593> add "for client session id ..." to the log message ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java (line 286) <https://reviews.apache.org/r/25160/#comment180602> this needs more explanation. Can you add comments and/or test plan ? I actually liked the fact that in the previous version of this test you had a lot of committed writes and all was missing seemed to be to check that the number of iterations to clear the reads depends on the number of reads and not the number of committed writes. This would show they're not blocked by the committed writes. Here you have less of both and its not clear what's happening or whether this tests no starvation. Also, the last check seems insufficient - reads may be in pending blocked behind something, check that they were done. ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 217) <https://reviews.apache.org/r/25160/#comment180606> can you please add a comment about this here ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 242) <https://reviews.apache.org/r/25160/#comment180607> in that case please change to == and add a comment ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java (line 267) <https://reviews.apache.org/r/25160/#comment180608> same as before - Alexander Shraer On Feb. 16, 2016, 7:04 a.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 7:04 a.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
