[ https://issues.apache.org/jira/browse/ZOOKEEPER-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175315#comment-15175315 ]
Hadoop QA commented on ZOOKEEPER-2377: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12790890/ZOOKEEPER-2377.patch against trunk revision 1733221. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3056//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3056//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3056//console This message is automatically generated. > zkServer.sh should resolve canonical path from symlinks > ------------------------------------------------------- > > Key: ZOOKEEPER-2377 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2377 > Project: ZooKeeper > Issue Type: Improvement > Components: scripts > Affects Versions: 3.4.8 > Environment: Centos 6 > Reporter: Siddhartha > Priority: Minor > Attachments: ZOOKEEPER-2377.patch, ZOOKEEPER-2377.patch > > > If zkServer.sh is started from a symlink, it is not able to correctly source > the other scripts because it looks in the wrong path. > Attached patch fixes this by first resolving absolute path to the script. -- This message was sent by Atlassian JIRA (v6.3.4#6332)