[
https://issues.apache.org/jira/browse/ZOOKEEPER-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177363#comment-15177363
]
Siddhartha commented on ZOOKEEPER-2377:
---------------------------------------
2) Haha yes, left over from my testing sessions, sorry.
4) Good point.
Keeping in mind that this feature did not even exist till now, we can choose to
support one degree symlinks only. In that case, we do not even have to use
readline as ls -l will be sufficient.
Alternatively, if we want to now start supporting multiple symlink traversals,
then we can retain readlink -f usage. Though of course as you pointed out, this
will lead to difference in behaviour across different platforms.
If Zookeeper has a policy to behave strictly the same across all platforms,
then I think we should go with simple one step symlink support only. Otherwise
readline -f is a neat feature to support and I think we should have that. So
your call :)
Implementing our own readlink function sounds overkill to me :P
{quote}
Last but not least, I personally like to append a ".n", where n > 1, just
before the ".patch" suffix. It makes easy to quickly glance over which patch is
the latest one and doesn't break Jenkins. Just a suggestion.
{quote}
Thanks, will follow henceforth. I was just following
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute, where it
says:
bq. In this case the updated patch should be re-attached to the Jira with the
same name. Jira will archive the older version of the patch and make the new
patch the active patch.
This page should be updated with above instructions :)
Thanks for testing and the review.
> zkServer.sh should resolve canonical path from symlinks
> -------------------------------------------------------
>
> Key: ZOOKEEPER-2377
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2377
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.4.8
> Environment: Centos 6
> Reporter: Siddhartha
> Assignee: Siddhartha
> Priority: Minor
> Attachments: ZOOKEEPER-2377.patch, ZOOKEEPER-2377.patch
>
>
> If zkServer.sh is started from a symlink, it is not able to correctly source
> the other scripts because it looks in the wrong path.
> Attached patch fixes this by first resolving absolute path to the script.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
