I think that would break qabot as well. Perhaps we should bite off one thing at a time. Moving to git alone is going to be a decent amount of work.
Patrick On Thu, Mar 10, 2016 at 9:34 AM, Flavio Junqueira <f...@apache.org> wrote: > This is fairly new for BK and we aren't requiring patches to be attached to > the corresponding jira, although there is a script that posts a comment on > the jira with the PR link. > > Kafka is also not requiring that folks post patches to the jira and post > comments with the PR link. > > The downside is that often the discussion around the patch ends up split > between github and jira. > > -Flavio > >> On 10 Mar 2016, at 17:27, Patrick Hunt <ph...@apache.org> wrote: >> >> Hm. Looks pretty straightforward - although in our case we have to >> consider that git repos already exist (for bk it was new). From the >> lucene infra jira it looks like they said to recreate the git repo and >> mirror. The additional side effect of doing that would be that all the >> "limbo" PRs will get blown away. >> >> As part of this change we'll need to consider how to change our HTC >> process. e.g. do we still want to require folks to attach patches to >> jiras or can we just use PRs to do it. If so how. What about review >> process. >> >> How is BK handling this? >> >> Patrick >> >> On Thu, Mar 10, 2016 at 9:20 AM, Flavio Junqueira >> <fpjunque...@yahoo.com.invalid> wrote: >>> Right, we moved to a git repo when the project became TLP: >>> >>> https://issues.apache.org/jira/browse/INFRA-8701 >>> <https://issues.apache.org/jira/browse/INFRA-8701> >>> >>> -Flavio >>> >>>> On 10 Mar 2016, at 17:12, Patrick Hunt <ph...@apache.org> wrote: >>>> >>>> Hm, that seems to be about github integration, see this for what >>>> lucene/solr recently did: >>>> https://issues.apache.org/jira/browse/INFRA-11056 "Migrate Lucene >>>> project from SVN to Git." >>>> >>>> I'm also +1 for git. >>>> >>>> Patrick >>>> >>>> >>>> On Thu, Mar 10, 2016 at 8:41 AM, Flavio Junqueira <f...@apache.org> wrote: >>>>> Here is the infra ticket for bookkeeper: >>>>> >>>>> https://issues.apache.org/jira/browse/INFRA-10679 >>>>> <https://issues.apache.org/jira/browse/INFRA-10679> >>>>> >>>>> -Flavio >>>>> >>>>>> On 10 Mar 2016, at 16:27, Raúl Gutiérrez Segalés <r...@itevenworks.net> >>>>>> wrote: >>>>>> >>>>>> I am +1 on moving to git as well. >>>>>> >>>>>> What did it take for other Apache projects? >>>>>> >>>>>> -rgs >>>>>> On Mar 10, 2016 7:09 AM, "Flavio Junqueira" <f...@apache.org> wrote: >>>>>> >>>>>>> I'd like to move to git... >>>>>>> >>>>>>> -Flavio >>>>>>> >>>>>>>> On 10 Mar 2016, at 15:07, Patrick Hunt <ph...@apache.org> wrote: >>>>>>>> >>>>>>>> I could see us turning it on if we move to git as our source repo. >>>>>>>> However I'm recommending we turn it _off_ until then. Interestingly >>>>>>>> there's a discussion going on right now in apache infra about this >>>>>>>> (github mirrors and PRs), I'll let you know. >>>>>>>> >>>>>>>> That said, is there any interest to move to git and drop svn? I'd like >>>>>>>> to move personally, hadoop moved a while back and lucene/solr just >>>>>>>> moved recently. I think it's a pretty well worn path if we're >>>>>>>> interested to do so. >>>>>>>> >>>>>>>> Patrick >>>>>>>> >>>>>>>> On Thu, Mar 10, 2016 at 12:36 AM, Flavio Junqueira <f...@apache.org> >>>>>>> wrote: >>>>>>>>> I did mean turning it on, which is apparently the opposite of what Pat >>>>>>> is proposing. Sorry about the confusion. =) >>>>>>>>> >>>>>>>>> -Flavio >>>>>>>>> >>>>>>>>>> On 10 Mar 2016, at 08:01, Raúl Gutiérrez Segalés >>>>>>>>>> <r...@itevenworks.net> >>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> On Mar 9, 2016 11:26 PM, "Flavio Junqueira" <f...@apache.org> wrote: >>>>>>>>>>> >>>>>>>>>>> +1 for accepting requesting to infra to accept PRs via github. We've >>>>>>> done >>>>>>>>>> the transition in BookKeeper and have been doing it in Kafka for a >>>>>>> while, >>>>>>>>>> it works pretty well. >>>>>>>>>> >>>>>>>>>> Wait - you mean the other way around? Pat suggested turning off PRs >>>>>>>>>> in >>>>>>>>>> github... >>>>>>>>>> >>>>>>>>>> -rgs >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I'm happy you brought this up, Pay, I've been thinking about it. >>>>>>>>>>> >>>>>>>>>>> -Flavio >>>>>>>>>>> >>>>>>>>>>>> On 10 Mar 2016, at 00:38, Patrick Hunt <ph...@apache.org> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi folks. If you look on github.com you'll see a number of pull >>>>>>>>>>>> request (41 atm) that are effectively in limbo given we don't >>>>>>>>>>>> accept >>>>>>>>>>>> pull requests that way: >>>>>>>>>>>> https://github.com/apache/zookeeper/pulls >>>>>>>>>>>> >>>>>>>>>>>> rather through our Jira process >>>>>>>>>>>> >>>>>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute >>>>>>>>>>>> >>>>>>>>>>>> someday we might move to git, but for the time being it seems like >>>>>>>>>>>> we >>>>>>>>>>>> should do something about this. >>>>>>>>>>>> >>>>>>>>>>>> I was thinking about contacting Apache infra and asking them if >>>>>>>>>>>> they >>>>>>>>>>>> can turn off accepting pull requests at github.com, just wanted to >>>>>>>>>>>> check with dev@ to see if this makes sense or do folks want to do >>>>>>>>>>>> something else? If I don't hear back anything negative in the next >>>>>>> few >>>>>>>>>>>> days I'll ping infra about shutting down acceptance of pull >>>>>>>>>>>> requests >>>>>>>>>>>> (may not be possible but I'll check). I'm not talking about >>>>>>>>>>>> removing >>>>>>>>>>>> the mirror to be clear, just shutting down accepting pull requests >>>>>>>>>>>> on >>>>>>>>>>>> the mirror. >>>>>>>>>>>> >>>>>>>>>>>> Patrick >>>>>>>>>>>> >>>>>>>>>>>> ps. regardless we probably need to get back to everyone and ask >>>>>>>>>>>> them >>>>>>>>>>>> to follow the HTC page.... I don't seem to be able to close out the >>>>>>>>>>>> PRs, just comment on them, so that's going to be a possible issue >>>>>>>>>>>> as >>>>>>>>>>>> well.... arg. >>>>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>> >>> >
