[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200145#comment-15200145
 ] 

Kazuaki Banzai commented on ZOOKEEPER-2391:
-------------------------------------------

Thank you for replying this report.
This is my first bug report and I don't understand the process of contribution 
well.
So please let me ask some questions.
>>Do you want to update the docs as well in your patch?
Does "the docs" mean the comment of Javadoc or something else?
I added the documentation tag because I wrote Javadoc comment(I'm sorry if I 
misunderstand the use of the tag).
>>Also, I think we need to fix this in branches 3.4, 3.5, and trunk, yes?
Yes.
I wrote this patch in trunk branch, but I didn't check the code in 3.4 and 3.5.
Should I test the code in 3.4 and 3.5?

> setMin/MaxSessionTimeout of ZookeeperServer are implemented in quite a weak 
> way
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2391
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2391
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: documentation, server
>            Reporter: Kazuaki Banzai
>            Assignee: Kazuaki Banzai
>            Priority: Minor
>         Attachments: ZOOKEEPER-2391.patch
>
>
> setMin/MaxSessionTimeout of ZookeeperServer are implemented in quite a weak 
> way.
> * -1 restores the default, but this is not documented.
> * values < -1 are permitted but make no sense.
> * min > max is permitted but makes not sense.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to