[
https://issues.apache.org/jira/browse/ZOOKEEPER-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255613#comment-15255613
]
Hadoop QA commented on ZOOKEEPER-2391:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12800421/ZOOKEEPER-2391-3.patch
against trunk revision 1738012.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3143//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3143//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3143//console
This message is automatically generated.
> setMin/MaxSessionTimeout of ZookeeperServer are implemented in quite a weak
> way
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2391
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Kazuaki Banzai
> Assignee: Kazuaki Banzai
> Priority: Minor
> Fix For: 3.4.8, 3.5.0
>
> Attachments: ZOOKEEPER-2391-2.patch, ZOOKEEPER-2391-3.4-2.patch,
> ZOOKEEPER-2391-3.4.patch, ZOOKEEPER-2391-3.patch, ZOOKEEPER-2391.patch
>
>
> setMin/MaxSessionTimeout of ZookeeperServer are implemented in quite a weak
> way.
> * -1 restores the default, but this is not documented.
> * values < -1 are permitted but make no sense.
> * min > max is permitted but makes not sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
