[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217496#comment-15217496
]
Flavio Junqueira commented on ZOOKEEPER-2141:
---------------------------------------------
Ok, I checked the code [~eribeiro] has pointed out and it seems to be fairly
harmless because it is in the equals code of the new cache class and I haven't
seen it called anywhere else other than one test case
({{testSerializeDesirialize}}). We should fix it nonetheless.
Can we simply remove that synchronization block around {{aclIndex}}? Would it
make a significant difference to the semantics of the method? Also, since we
are on the topic, has anyone checked carefully the synchronization in this
patch? There are 22 matches and some of them were part of the code base
already. I'm sure [~adammilnesmith] checked it carefully, but I wonder if
[~fournc] or maybe [~phunt] have been able to do it too just to have a second
opinion.
> ACL cache in DataTree never removes entries
> -------------------------------------------
>
> Key: ZOOKEEPER-2141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2141
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.6
> Reporter: Karol Dudzinski
> Assignee: Adam Milne-Smith
> Priority: Blocker
> Fix For: 3.4.9, 3.5.2
>
> Attachments: ZOOKEEPER-2141-3.4.patch, ZOOKEEPER-2141.patch,
> ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch,
> ZOOKEEPER-2141.patch
>
>
> The problem and potential solutions are discussed in
> http://mail-archives.apache.org/mod_mbox/zookeeper-user/201502.mbox/browser
> I will attach a proposed patch in due course.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
