[ https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217648#comment-15217648 ]
Flavio Junqueira commented on ZOOKEEPER-2141: --------------------------------------------- That's an option and I'm fine if you want to move the code to the tests, but I'm thinking that you have a couple of other options here: # Make the synchronization of this and that non-overlapping. You can remove the synchronized modifier from the signature, have a {{synchronized (that)}} block that collects the values of the variables to be compared, and have a {{synchronized (this)} block that performs the comparisons with the local instance variables. # Make aclIndex an AtomicLong would also work, although it might be overkill. > ACL cache in DataTree never removes entries > ------------------------------------------- > > Key: ZOOKEEPER-2141 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2141 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.6 > Reporter: Karol Dudzinski > Assignee: Adam Milne-Smith > Priority: Blocker > Fix For: 3.4.9, 3.5.2 > > Attachments: ZOOKEEPER-2141-3.4.patch, ZOOKEEPER-2141.patch, > ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, > ZOOKEEPER-2141.patch > > > The problem and potential solutions are discussed in > http://mail-archives.apache.org/mod_mbox/zookeeper-user/201502.mbox/browser > I will attach a proposed patch in due course. -- This message was sent by Atlassian JIRA (v6.3.4#6332)