[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224818#comment-15224818
]
Edward Ribeiro commented on ZOOKEEPER-2141:
-------------------------------------------
Hi [~fournc], thank you for your consideration! :) And sorry for the delay to
answer. Well, *I looked carefully and it's +1, IMHO.*
[~adammilnesmith], congrats for the good work! I would only to suggest a little
thing (but see, this is *not* required to commit this patch, I am +1 in spite
of this): you could have made {{aclIndex}} a volatile as below:
{code}
volatile long aclIndex = 0;
{code}
See this link for further information about the advantage of using
{{volatiles}} with long/int/double: http://stackoverflow.com/a/3038233/2698109
. But again, *I am +1 even without this change*.
Cheers,
Ed
> ACL cache in DataTree never removes entries
> -------------------------------------------
>
> Key: ZOOKEEPER-2141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2141
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.6
> Reporter: Karol Dudzinski
> Assignee: Adam Milne-Smith
> Priority: Blocker
> Fix For: 3.4.9, 3.5.2
>
> Attachments: ZOOKEEPER-2141-3.4.patch, ZOOKEEPER-2141.patch,
> ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch,
> ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch
>
>
> The problem and potential solutions are discussed in
> http://mail-archives.apache.org/mod_mbox/zookeeper-user/201502.mbox/browser
> I will attach a proposed patch in due course.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
