[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220606#comment-15220606
 ] 

Flavio Junqueira commented on ZOOKEEPER-2141:
---------------------------------------------

I'm fine with the version that moves the assertion to the test. I think you've 
introduced some white spaces in and I was wondering if you could just elaborate 
a bit on this comments:

{noformat}
-
+    
     /*
     For reasons we don't all agree with, AtomicLong does not have an equals.
      */
{noformat}

both really minor, hope you don't mind.

> ACL cache in DataTree never removes entries
> -------------------------------------------
>
>                 Key: ZOOKEEPER-2141
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2141
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.6
>            Reporter: Karol Dudzinski
>            Assignee: Adam Milne-Smith
>            Priority: Blocker
>             Fix For: 3.4.9, 3.5.2
>
>         Attachments: ZOOKEEPER-2141-3.4.patch, 
> ZOOKEEPER-2141-equalsMovedToTest.patch, ZOOKEEPER-2141.patch, 
> ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, 
> ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch
>
>
> The problem and potential solutions are discussed in 
> http://mail-archives.apache.org/mod_mbox/zookeeper-user/201502.mbox/browser
> I will attach a proposed patch in due course.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to