Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672385
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
protected NIOServerCnxn createConnection(SocketChannel sock,
SelectionKey sk, SelectorThread selectorThread) throws
IOException {
- return new NIOServerCnxn(zkServer, sock, sk, this, selectorThread);
+
+ NIOServerCnxn cnxn = null;
+
+ if (serverCnxnClassCtr != null) {
--- End diff --
why not set serverCnxnClassCtr to NIOServerCnxn by default to avoid looking
up the right constructor every time we want to create a new connection (a bit
of a hot path)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
