Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86672419 --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java --- @@ -105,8 +115,26 @@ public void channelConnected(ChannelHandlerContext ctx, LOG.trace("Channel connected " + e); } - NettyServerCnxn cnxn = new NettyServerCnxn(ctx.getChannel(), - zkServer, NettyServerCnxnFactory.this); + NettyServerCnxn cnxn = null; + if (serverCnxnClassCtr != null) { --- End diff -- same as for NIO, lets set serverCnxnClassCtr to NettyServerCnxn by default
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---