Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r89283922
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -151,9 +153,13 @@
*/
public final static int telnetCloseCmd = 0xfff4fffd;
- public final static HashMap<Integer, String> cmd2String =
+ final static HashMap<Integer, String> cmd2String =
--- End diff --
If we can remove this `public`, then I think we should. Also agree with the
consistent `Map` declaration comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
