[
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706783#comment-15706783
]
ASF GitHub Bot commented on ZOOKEEPER-2325:
-------------------------------------------
GitHub user breed opened a pull request:
https://github.com/apache/zookeeper/pull/117
ZOOKEEPER-2325: Data inconsistency if all snapshots empty or missing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/breed/zookeeper ZOOKEEPER-2325
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 02bf3d57786d51da205e78a070a45703da21f916
Author: Benjamin Reed <br...@fb.com>
Date: 2016-11-29T22:08:22Z
ZOOKEEPER-2325: Data inconsistency if all snapshots empty or missing
----
> Data inconsistency if all snapshots empty or missing
> ----------------------------------------------------
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.6
> Reporter: Andrew Grasso
> Assignee: Andrew Grasso
> Priority: Critical
> Attachments: ZOOKEEPER-2325-test.patch, ZOOKEEPER-2325.001.patch,
> zk.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found.
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
