[
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712905#comment-15712905
]
ASF GitHub Bot commented on ZOOKEEPER-2325:
-------------------------------------------
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90523812
--- Diff:
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import java.io.IOException;
+import java.io.File;
+import java.io.PrintWriter;
+import java.util.List;
+import java.util.LinkedList;
+
+import org.apache.log4j.Logger;
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.PortAssignment;
+import org.apache.zookeeper.WatchedEvent;
+import org.apache.zookeeper.Watcher;
+import org.apache.zookeeper.ZKTestCase;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.server.quorum.Leader.Proposal;
+import org.apache.zookeeper.server.ServerCnxnFactory;
+import org.apache.zookeeper.server.SyncRequestProcessor;
+import org.apache.zookeeper.server.ZooKeeperServer;
+import org.apache.zookeeper.server.persistence.FileTxnSnapLog;
+import org.junit.Assert;
+import org.junit.Test;
+
+/** If snapshots are corrupted to the empty file or deleted, Zookeeper
should
+ * not proceed to read its transactiong log files
+ * Test that zxid == -1 in the presence of emptied/deleted snapshots
+ */
+public class EmptiedSnapshotRecoveryTest extends ZKTestCase implements
Watcher {
+ private static final Logger LOG =
Logger.getLogger(RestoreCommittedLogTest.class);
+ private static String HOSTPORT = "127.0.0.1:" +
PortAssignment.unique();
+ private static final int CONNECTION_TIMEOUT = 3000;
+ private static final int N_TRANSACTIONS = 150;
+ private static final int SNAP_COUNT = 100;
+
+ public void runTest(boolean leaveEmptyFile) throws Exception {
+ File tmpSnapDir = ClientBase.createTmpDir();
+ File tmpLogDir = ClientBase.createTmpDir();
+ ClientBase.setupTestEnv();
+ ZooKeeperServer zks = new ZooKeeperServer(tmpSnapDir, tmpLogDir,
3000);
+ SyncRequestProcessor.setSnapCount(SNAP_COUNT);
+ final int PORT = Integer.parseInt(HOSTPORT.split(":")[1]);
+ ServerCnxnFactory f = ServerCnxnFactory.createFactory(PORT, -1);
+ f.startup(zks);
+ Assert.assertTrue("waiting for server being up ",
+ ClientBase.waitForServerUp(HOSTPORT,CONNECTION_TIMEOUT));
+ ZooKeeper zk = new ZooKeeper(HOSTPORT, CONNECTION_TIMEOUT, this);
+ try {
+ for (int i = 0; i< N_TRANSACTIONS; i++) {
+ zk.create("/node-" + i, new byte[0], Ids.OPEN_ACL_UNSAFE,
+ CreateMode.PERSISTENT);
+ }
+ } finally {
+ zk.close();
+ }
+ f.shutdown();
+ zks.shutdown();
+ Assert.assertTrue("waiting for server to shutdown",
+ ClientBase.waitForServerDown(HOSTPORT,
CONNECTION_TIMEOUT));
+
+ // start server again with intact database
+ zks = new ZooKeeperServer(tmpSnapDir, tmpLogDir, 3000);
+ zks.startdata();
+ long zxid = zks.getZKDatabase().getDataTreeLastProcessedZxid();
+ LOG.info("After clean restart, zxid = " + zxid);
+ Assert.assertTrue("zxid > 0", zxid > 0);
+ zks.shutdown();
+
+ // Make all snapshots empty
+ FileTxnSnapLog txnLogFactory = zks.getTxnLogFactory();
+ List<File> snapshots = txnLogFactory.findNRecentSnapshots(10);
+ Assert.assertTrue("We have a snapshot to corrupt",
snapshots.size() > 0);
+ for (File file: snapshots) {
+ if (leaveEmptyFile) {
+ new PrintWriter(file).close ();
+ }
+ else {
--- End diff --
yes that is ugly!
> Data inconsistency if all snapshots empty or missing
> ----------------------------------------------------
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.6
> Reporter: Andrew Grasso
> Assignee: Andrew Grasso
> Priority: Critical
> Attachments: ZOOKEEPER-2325-test.patch, ZOOKEEPER-2325.001.patch,
> zk.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found.
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
