Github user yufeldman commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r90782565 --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java --- @@ -71,7 +71,7 @@ NettyServerCnxnFactory factory; boolean initialized; - NettyServerCnxn(Channel channel, ZooKeeperServer zks, NettyServerCnxnFactory factory) { + public NettyServerCnxn(Channel channel, ZooKeeperServer zks, NettyServerCnxnFactory factory) { --- End diff -- I think I did this to match NIOServerCnxn constructor. It can be kept package level, as my test class is in the same package namespace. I can change it back, but it will be inconsistent with NIO
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---