Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90924628
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean initialized;
- NettyServerCnxn(Channel channel, ZooKeeperServer zks,
NettyServerCnxnFactory factory) {
+ public NettyServerCnxn(Channel channel, ZooKeeperServer zks,
NettyServerCnxnFactory factory) {
--- End diff --
@yufeldman Thanks for explaining, makes sense to me. It is required to run
the tests, however I do find another problem with tests: it looks like the
Netty tests (testNetty*) never run with current configuration. Proof: remove
the public access specifier appertain to `NettyServerCnxn` and all tests of
`ServerCxnExceptionsTest` still pass. We expect Netty related tests fail here
without public access specifier, right? Now put back the public for
`NettyServerCnxn` but remove the public access specifier appertains to
`NIOServercCnxn`, now all tests failed while we expect only NIO tests fail but
Netty tests pass.
It's likely caused by the intervening of the java system properties that
controls the Netty vs NIO server selection. One solution is to split the
`ServerCxnExceptionsTest` into Netty and NIO specific tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
