[
https://issues.apache.org/jira/browse/ZOOKEEPER-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796634#comment-15796634
]
ASF GitHub Bot commented on ZOOKEEPER-2656:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/140#discussion_r94510094
--- Diff: src/java/test/org/apache/zookeeper/ServerConfigTest.java ---
@@ -57,4 +59,16 @@ public void testTooManyArguments() {
String[] args = {"2181", "/data/dir", "60000", "10000", "9999"};
serverConfig.parse(args);
}
-}
+
+ boolean checkEquality(String a, String b) {
+ return a != null && a.equals(b);
+ }
+
+ boolean checkEquality(String a, File b) {
+ try {
+ return a != null && b != null && new
File(a).getCanonicalPath().equals(b.getCanonicalPath());
+ } catch (IOException e) {
--- End diff --
Oh, I see. It is because the method overloading. But could we add a comment
like ``//DO NOTHING`` or maybe log the error in the ``catch`` body? Empty catch
blocks make me uncomfortable. :) But I am fine as is, nevertheless.
> Fix ServerConfigTest#testValidArguments test case failures
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-2656
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2656
> Project: ZooKeeper
> Issue Type: Test
> Reporter: Rakesh R
> Assignee: Michael Han
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> This jira to fix ServerConfigTest#testValidArguments test case failure.
> Reference:
> https://builds.apache.org/job/ZooKeeper-trunk/3207/testReport/org.apache.zookeeper/ServerConfigTest/testValidArguments/
> {code}
> Error Message
> expected: java.lang.String</data/dir> but was: java.io.File</data/dir>
> Stacktrace
> junit.framework.AssertionFailedError: expected: java.lang.String</data/dir>
> but was: java.io.File</data/dir>
> at
> org.apache.zookeeper.ServerConfigTest.testValidArguments(ServerConfigTest.java:48)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
