[
https://issues.apache.org/jira/browse/ZOOKEEPER-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796752#comment-15796752
]
ASF GitHub Bot commented on ZOOKEEPER-2656:
-------------------------------------------
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/140
@eribeiro Yeah, I read about the difference but I think in our context it
is pretty safe to use File.equals given the actual string literal returned from
getDataDir and the string it compares against would be exact the same (so the
corner cases does not apply here). Initially I used getCanonicalPath for safety
but since you brought this up and I thought about it, I feel it's OK. Do you
see any practical failure cases that we would run into here by using
File.equals?
> Fix ServerConfigTest#testValidArguments test case failures
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-2656
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2656
> Project: ZooKeeper
> Issue Type: Test
> Reporter: Rakesh R
> Assignee: Michael Han
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> This jira to fix ServerConfigTest#testValidArguments test case failure.
> Reference:
> https://builds.apache.org/job/ZooKeeper-trunk/3207/testReport/org.apache.zookeeper/ServerConfigTest/testValidArguments/
> {code}
> Error Message
> expected: java.lang.String</data/dir> but was: java.io.File</data/dir>
> Stacktrace
> junit.framework.AssertionFailedError: expected: java.lang.String</data/dir>
> but was: java.io.File</data/dir>
> at
> org.apache.zookeeper.ServerConfigTest.testValidArguments(ServerConfigTest.java:48)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
