[
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818534#comment-15818534
]
ASF GitHub Bot commented on ZOOKEEPER-2642:
-------------------------------------------
Github user fpj commented on the issue:
https://github.com/apache/zookeeper/pull/122
Just so that I understand, when are we going to be removing this methods,
in trunk? I'm asking this for two reasons:
1. So that users know in which version these methods are going away
2. What changes we need to apply to trunk. In trunk, we would need to at
least change in the admin class `reconfig()` to `reconfigure()`, but it sounds
like we don't need to bring back the old `reconfig` methods.
> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.5.2
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin.
> It appears this was done to document that these are methods have access
> restrictions. However, this change breaks Apache Curator (and possibly other
> clients). Curator APIs will have to be changed and/or special methods need to
> be added. A breaking change of this kind should only be done when the benefit
> is overwhelming. In this case, the same information can be conveyed with
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig()
> methods back to the ZooKeeper class with additional documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
