[
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825579#comment-15825579
]
ASF GitHub Bot commented on ZOOKEEPER-2642:
-------------------------------------------
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
>> Breaking changes should be in a 3.6 version.
Sounds OK to me.
>> We need to either create a new issue or have a different pull request
for 3.5 under this same issue
I think this pull request (122) should target branch 3.5, because it keeps
the old API. We need create a new PR that target master which only contain
updates to the API name (reconfig -> reconfigure) and some doc / test updates
without bringing back the old APIs.
@Randgalt Could you update the base branch of this PR to be branch-3.5
instead of master? I think this PR is ready to land in branch-3.5.
@fpj I can create a new PR target master that only contain API name
changes, if @Randgalt does not get ahead of me on this work.
> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.5.2
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin.
> It appears this was done to document that these are methods have access
> restrictions. However, this change breaks Apache Curator (and possibly other
> clients). Curator APIs will have to be changed and/or special methods need to
> be added. A breaking change of this kind should only be done when the benefit
> is overwhelming. In this case, the same information can be conveyed with
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig()
> methods back to the ZooKeeper class with additional documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
