[
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941562#comment-15941562
]
ASF GitHub Bot commented on ZOOKEEPER-2280:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108027783
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
zkServer, NettyServerCnxnFactory.this);
ctx.setAttachment(cnxn);
+ InetAddress addr =
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+ Set<NettyServerCnxn> s = ipMap.get(addr);
+ if (s != null) {
+ synchronized (s) {
+ int cnxncount = s.size();
+ if (maxClientCnxns > 0 && cnxncount >= maxClientCnxns)
{
+ LOG.warn("Closed new connection from address {}
({} connections established) - max is {}",
+ addr, cnxncount, maxClientCnxns);
+ cnxn.close();
+ ctx.getChannel().close().awaitUninterruptibly();
--- End diff --
TODO: double-check that this is the right order of closing cnxn and channel
> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.6, 3.5.0, 3.5.1
> Reporter: Edward Ribeiro
> Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it
> doesn't enforce this limit in the code.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
