[ https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943731#comment-15943731 ]
ASF GitHub Bot commented on ZOOKEEPER-2280: ------------------------------------------- Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/208#discussion_r108229036 --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java --- @@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx, zkServer, NettyServerCnxnFactory.this); ctx.setAttachment(cnxn); + InetAddress addr = ((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress(); + Set<NettyServerCnxn> s = ipMap.get(addr); --- End diff -- Not sure if this is an issue or not, but if multiple connections (from a new address) hit this line before reaching the next one, the maxclientcnxns will never be checked as factory.ipMap.get(address) will return null for all of the connections? > NettyServerCnxnFactory doesn't honor maxClientCnxns param > --------------------------------------------------------- > > Key: ZOOKEEPER-2280 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Reporter: Edward Ribeiro > Assignee: Edward Ribeiro > Fix For: 3.5.4, 3.6.0 > > Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch > > > Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it > doesn't enforce this limit in the code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)