[ https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979476#comment-15979476 ]
Hadoop QA commented on ZOOKEEPER-2733: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 70 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/574//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/574//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/574//console This message is automatically generated. > Cleanup findbug warnings in branch-3.4: Dodgy code Warnings > ----------------------------------------------------------- > > Key: ZOOKEEPER-2733 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2733 > Project: ZooKeeper > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Abraham Fine > Fix For: 3.4.11 > > > Please refer the attached sheet in parent jira. Below is the details of > findbug warnings. > {code} > DB > org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream, > byte[]) uses the same code for two branches > DLS Dead store to txn in > org.apache.zookeeper.server.quorum.LearnerHandler.packetToString(QuorumPacket) > NP Load of known null value in > org.apache.zookeeper.server.PrepRequestProcessor.pRequest(Request) > NP Possible null pointer dereference in > org.apache.zookeeper.server.PurgeTxnLog.purgeOlderSnapshots(FileTxnSnapLog, > File) due to return value of called method > NP Possible null pointer dereference in > org.apache.zookeeper.server.PurgeTxnLog.purgeOlderSnapshots(FileTxnSnapLog, > File) due to return value of called method > NP Load of known null value in > org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream, > byte[]) > NP Load of known null value in > org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream, > byte[], QuorumAuth$Status) > NP Possible null pointer dereference in > org.apache.zookeeper.server.upgrade.UpgradeMain.copyFiles(File, File, String) > due to return value of called method > RCN Redundant nullcheck of bytes, which is known to be non-null in > org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next() > SF Switch statement found in > org.apache.zookeeper.server.PrepRequestProcessor.pRequest(Request) where > default case is missing > SF Switch statement found in > org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(int, long, > Request, Record, boolean) where default case is missing > SF Switch statement found in > org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerReceiver.run() > where default case is missing > SF Switch statement found in > org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection$ToSend) > where default case is missing > SF Switch statement found in > org.apache.zookeeper.server.quorum.Follower.processPacket(QuorumPacket) where > default case is missing > SF Switch statement found in > org.apache.zookeeper.server.quorum.Observer.processPacket(QuorumPacket) where > default case is missing > ST Write to static field > org.apache.zookeeper.server.SyncRequestProcessor.randRoll from instance > method org.apache.zookeeper.server.SyncRequestProcessor.run() > UrF Unread public/protected field: > org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.err > UrF Unread public/protected field: > org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.path > UrF Unread public/protected field: > org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.stat > UrF Unread public/protected field: > org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.type > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)