[
https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015986#comment-16015986
]
ASF GitHub Bot commented on ZOOKEEPER-2733:
-------------------------------------------
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117279935
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -628,14 +628,7 @@ protected void pRequest(Request request) throws
RequestProcessorException {
break;
//All the rest don't need to create a Txn - just verify session
- case OpCode.sync:
- case OpCode.exists:
- case OpCode.getData:
- case OpCode.getACL:
- case OpCode.getChildren:
- case OpCode.getChildren2:
- case OpCode.ping:
- case OpCode.setWatches:
+ default:
--- End diff --
This will execute if any `unknown type` and is not expected, isn't it?
We could keep the existing case checks and add default like,
```
zks.sessionTracker.checkSession(request.sessionId,
request.getOwner());
break;
default:
LOG.warn("unknown type " + request.type);
break;
```
> Cleanup findbug warnings in branch-3.4: Dodgy code Warnings
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-2733
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2733
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> DB
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream,
> byte[]) uses the same code for two branches
> DLS Dead store to txn in
> org.apache.zookeeper.server.quorum.LearnerHandler.packetToString(QuorumPacket)
> NP Load of known null value in
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(Request)
> NP Possible null pointer dereference in
> org.apache.zookeeper.server.PurgeTxnLog.purgeOlderSnapshots(FileTxnSnapLog,
> File) due to return value of called method
> NP Possible null pointer dereference in
> org.apache.zookeeper.server.PurgeTxnLog.purgeOlderSnapshots(FileTxnSnapLog,
> File) due to return value of called method
> NP Load of known null value in
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream,
> byte[])
> NP Load of known null value in
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream,
> byte[], QuorumAuth$Status)
> NP Possible null pointer dereference in
> org.apache.zookeeper.server.upgrade.UpgradeMain.copyFiles(File, File, String)
> due to return value of called method
> RCN Redundant nullcheck of bytes, which is known to be non-null in
> org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next()
> SF Switch statement found in
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest(Request) where
> default case is missing
> SF Switch statement found in
> org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(int, long,
> Request, Record, boolean) where default case is missing
> SF Switch statement found in
> org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerReceiver.run()
> where default case is missing
> SF Switch statement found in
> org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection$ToSend)
> where default case is missing
> SF Switch statement found in
> org.apache.zookeeper.server.quorum.Follower.processPacket(QuorumPacket) where
> default case is missing
> SF Switch statement found in
> org.apache.zookeeper.server.quorum.Observer.processPacket(QuorumPacket) where
> default case is missing
> ST Write to static field
> org.apache.zookeeper.server.SyncRequestProcessor.randRoll from instance
> method org.apache.zookeeper.server.SyncRequestProcessor.run()
> UrF Unread public/protected field:
> org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.err
> UrF Unread public/protected field:
> org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.path
> UrF Unread public/protected field:
> org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.stat
> UrF Unread public/protected field:
> org.apache.zookeeper.server.upgrade.DataTreeV1$ProcessTxnResult.type
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
