[ https://issues.apache.org/jira/browse/ZOOKEEPER-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049236#comment-16049236 ]
Hadoop QA commented on ZOOKEEPER-1782: -------------------------------------- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/788//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/788//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/788//console This message is automatically generated. > zookeeper.superUser is not as super as superDigest > -------------------------------------------------- > > Key: ZOOKEEPER-1782 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1782 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.5 > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > Attachments: zk-1782.patch, zk-1782.patch > > > The zookeeper.superUser system property does not fully grant super user > privileges, like zookeeper.DigestAuthenticationProvider.superDigest does. > zookeeper.superUser only has as many privileges as the sasl ACLs on the znode > being accessed. This means that if a znode only has digest ACLs > zookeeper.superUser is ignored. Or if a znode has a single sasl ACL that > only has read privileges zookeeper.superUser only has read privileges. > The reason for this is that SASLAuthenticationProvider implements the > superUser check in the matches method, instead of having the super user > include a new Id("super","") as Digest does. -- This message was sent by Atlassian JIRA (v6.4.14#64029)