Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/306
  
    @andschwa 
    Patch looks good to me. The readme update looks good too. 
    
    I also verified Linux and Mac c client builds with the patch. Unfortunately 
I don't have a windows box to test. Can you please describe what kinds of test 
/ integration test you did on windows? 
    
    There are two remaining issues:
    * Can you please update the pull request description by adding a brief 
description on what this patch is for and how it did it. The pull request 
description will be part of commit message, and it's good to have a informative 
commit message.
    
    * This pull request is targeting master, which is not going to be released 
soon. branch-3.5 and branch-3.4 are branches for next releases, are you going 
to send separate pull requests to those branches, or you are fine just with 
this merged into master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to