Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127627096
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -64,10 +65,15 @@
public MainThread(int clientPort, boolean preCreateDirs, String
configs)
throws IOException {
- this(clientPort, preCreateDirs, ClientBase.createTmpDir(),
configs);
+ this(clientPort, preCreateDirs, ClientBase.createTmpDir(),
configs, -1);
}
- public MainThread(int clientPort, boolean preCreateDirs, File
tmpDir, String configs)
+ public MainThread(int clientPort, boolean preCreateDirs, String
configs, int threshold)
--- End diff --
the `threshold` word in method signature doesn't say much so it requires
digging the code to see what it's all about. It would be nice to rename to
something closer to its intent (there are plenty of names in this patch
already).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
