Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127618910
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -460,11 +464,21 @@ public void processRequest(Request request) {
if (request.type == OpCode.closeSession) {
cnxn.sendCloseSession();
}
+ checkLatency(request);
} catch (IOException e) {
LOG.error("FIXMSG",e);
}
}
+ private void checkLatency(Request request) {
+ long requestWarnThresholdMs =
QuorumPeerConfig.getRequestWarnResponseThresholdMs();
+ long requestLatency = Time.currentElapsedTime() -
request.createTime;
+ if((requestWarnThresholdMs > -1 && requestLatency >
requestWarnThresholdMs) || requestWarnThresholdMs == 0) {
+ LOG.warn("Request " + request + " exceeded threshold. Took "
+ requestLatency + " ms.");
+ zks.serverStats().updateNumRequestsExceededThresholdTime();
--- End diff --
Cool! :)
nit: Two suggestions: to change the prefix from `update` to `inc` and use
`numRequestsAboveThresholdTime()` (up to you both).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
