[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096474#comment-16096474
 ] 

Michael Han commented on ZOOKEEPER-2792:
----------------------------------------

Thanks [~rakeshr] for reviewing! 

bq. Any specific reason to not merging QuorumCnxManagerTest test cases?

This test was introduced in ZOOKEEPER-1633 by Alex to provide an upgrade path 
from 3.4 to 3.5, so what it aimed to test (the upgrade logic) is only 
applicable to branch-3.4. Because of that, this class was not part of 
branch-3.5 in first place, and thus was not included as part of this forward 
porting patch.

bq. Need to merge below changes.

I've created a new sub-task ZOOKEEPER-2850 to do this work. As we discussed 
offline, the current patch is already too big to review / manage, so it's 
better to merge the following up improvement patches separately. I'll start 
doing this work once this patch landed in 3.5.


> [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.4 to 
> branch-3.5
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2792
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2792
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: quorum, security
>            Reporter: Rakesh R
>            Assignee: Michael Han
>             Fix For: 3.5.4, 3.6.0
>
>         Attachments: ZOOKEEPER-2792.patch
>
>
> This jira is to merge the basic working patch covering the authentication and 
> authorization of static(zoo.cfg) ZooKeeper servers from {{branch-3.4}} code 
> base.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to