[
https://issues.apache.org/jira/browse/ZOOKEEPER-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112145#comment-16112145
]
ASF GitHub Bot commented on ZOOKEEPER-2853:
-------------------------------------------
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/322#discussion_r131049471
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr,
Record txn)
LOG.warn("Current zxid " + hdr.getZxid()
--- End diff --
I like the suggestion here. Though ZK does not enforce such style, early
exists is my preference for reasons documented here:
https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
Though this change can be done separately as it's not an existing stylish
issue.
>> BTW,why do I see so many flaky changes?
Not sure about what flaky changes you are referring to? @maoling
> The lastZxidSeen in FileTxnLog.java is never being assigned
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-2853
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2853
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Minor
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> There is log in FileTxnLog#append to track the txn with smaller zxid than the
> last seen, but the lastZxidSeen is never being assigned, so that log is not
> printed when it's happened.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
