[ https://issues.apache.org/jira/browse/ZOOKEEPER-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112181#comment-16112181 ]
ASF GitHub Bot commented on ZOOKEEPER-2853: ------------------------------------------- Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/322#discussion_r131052685 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -118,7 +118,7 @@ fsyncWarningThresholdMS = fsyncWarningThreshold; } - long lastZxidSeen; + long lastMaxZxidSeen; --- End diff -- oh, last minute change left the issue here, was thinking of lastMaxZxidSeen will be more accurate, but thought a bit more and lastZxidSeen should be Ok too, so changed it back, forgot to change here. > The lastZxidSeen in FileTxnLog.java is never being assigned > ----------------------------------------------------------- > > Key: ZOOKEEPER-2853 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2853 > Project: ZooKeeper > Issue Type: Bug > Components: server > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > > There is log in FileTxnLog#append to track the txn with smaller zxid than the > last seen, but the lastZxidSeen is never being assigned, so that log is not > printed when it's happened. -- This message was sent by Atlassian JIRA (v6.4.14#64029)