Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/415#discussion_r149830970
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class LeaderStatsTest {
+ @Test
+ public void testSetProposalSize_SetMinMax() {
+ LeaderStats stats = new LeaderStats();
--- End diff --
Maybe we should check what the min and max are before a proposal is
received to make sure we set that behavior in stone.
---