Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r149833628
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java 
---
    @@ -0,0 +1,61 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.server.quorum;
    +
    +/**
    + * Provides live statistics about a running Leader.
    + */
    +class LeaderStats {
    +    /**
    +     * Size of the last generated proposal. This should fit into server's 
jute.maxbuffer setting.
    +     */
    +    private int lastProposalSize = 0;
    +
    +    /**
    +     * Size of the smallest proposal which has been generated since the 
server was started.
    +     */
    +    private int minProposalSize = -1;
    +
    +    /**
    +     * Size of the largest proposal which has been generated since the 
server was started.
    +     */
    +    private int maxProposalSize = 0;
    --- End diff --
    
    nit: can we set all of these to -1 for consistency


---

Reply via email to