[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269842#comment-16269842 ]
ASF GitHub Bot commented on ZOOKEEPER-2901: ------------------------------------------- Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r153668817 --- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java --- @@ -40,19 +39,21 @@ TTL; public static final long CONTAINER_EPHEMERAL_OWNER = Long.MIN_VALUE; - public static final long MAX_TTL = 0x0fffffffffffffffL; - public static final long TTL_MASK = 0x8000000000000000L; + public static final long MAX_TTL = 0x00ffffffffffffffL; + public static final long TTL_MASK = 0xff00000000000000L; + public static final long MAX_TTL_SERVER_ID = 0xfe; // 254 public static EphemeralType get(long ephemeralOwner) { if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { return CONTAINER; } - if (ephemeralOwner < 0) { + if ((ephemeralOwner & TTL_MASK) == TTL_MASK) { --- End diff -- In particular you need to add a bunch more testing to ensure this case is working properly. > Session ID that is negative causes mis-calculation of Ephemeral Type > -------------------------------------------------------------------- > > Key: ZOOKEEPER-2901 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.3 > Environment: Running 3.5.3-beta in Docker container > Reporter: Mark Johnson > Assignee: Jordan Zimmerman > Priority: Blocker > > In the code that determines the EphemeralType it is looking at the owner > (which is the client ID or connection ID): > EphemeralType.java: > public static EphemeralType get(long ephemeralOwner) { > if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { > return CONTAINER; > } > if (ephemeralOwner < 0) { > return TTL; > } > return (ephemeralOwner == 0) ? VOID : NORMAL; > } > However my connection ID is: > header.getClientId(): -720548323429908480 > This causes the code to think this is a TTL Ephemeral node instead of a > NORMAL Ephemeral node. > This also explains why this is random - if my client ID is non-negative > then the node gets added correctly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)