Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/495
  
    @brettKK Thanks for the fix. It'd be nice to add at least a unit test to 
cover the issue.
    
    I think adding the check alone is not enough here. Looking at the 
`serialize()` method, if `map` field is greater than 0, both `long` and `acls` 
fields must also be present.
    In other words, in `deserialize()` if (i>0) then both `long` and `acls` are 
mandatory. As a consequence  the else branch of the check should also be 
implemented and an exception should be thrown indicating that the archive 
cannot be deserialise, because the format is incorrect.
    
    Does it make sense?


---

Reply via email to