Github user LJ1043041006 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/495#discussion_r177351128
--- Diff:
src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java ---
@@ -109,16 +109,18 @@ public synchronized void deserialize(InputArchive ia)
throws IOException {
}
List<ACL> aclList = new ArrayList<ACL>();
Index j = ia.startVector("acls");
- while (!j.done()) {
- ACL acl = new ACL();
- acl.deserialize(ia, "acl");
- aclList.add(acl);
- j.incr();
+ if (j != null) {
--- End diff --
just as @anmolnar review, we should throw exception if j == null, so add
code just like
if (j == null){
throw Exception(error_message);
}
@maoling can this change be elegant?
---
