[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r181060856
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
    @@ -32,6 +32,7 @@
         private long minLatency = Long.MAX_VALUE;
         private long totalLatency = 0;
         private long count = 0;
    +    private long fsyncThresholdExceedCount = 0L;
    --- End diff --
    
    What do you think about using `AtomicLong` instead of synchronising every 
access?


---