[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

[phunt]

Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r183573019
  
    --- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java 
---
    @@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
             line = in.readLine();
             Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
             line = in.readLine();
    +        Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded: 
\\d+$", line));
    --- End diff --
    
    any chance we can add this to the very end of the output? We weren't very 
clear on order and in some cases existing monitoring may be expecting the 
original order. Appending helps wrt b/w compat.


---