[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

[rakeshadr]

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/466#discussion_r181823105
  
    --- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
    @@ -84,4 +92,17 @@ public void testSendCloseSession() throws Exception {
                 zk.close();
             }
         }
    +
    +    @Test
    +    public void testClientResponseStatsUpdate() throws IOException, 
InterruptedException, KeeperException {
    +        try (ZooKeeper zk = createClient()) {
    +            ProposalStats stats = 
serverFactory.getZooKeeperServer().serverStats().getClientResponseStats();
    +            assertEquals("", -1, stats.getLast());
    +
    +            zk.create("/a", "test".getBytes(), Ids.OPEN_ACL_UNSAFE,
    +                    CreateMode.PERSISTENT);
    +
    +            assertThat(stats.getLast(), greaterThan(0));
    --- End diff --
    
    Same comment as above...non-zero expected value.


---