Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r182332830
--- Diff:
src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java ---
@@ -75,9 +79,9 @@ public void commandRun() {
print("synced_followers",
leader.getForwardingFollowers().size());
print("pending_syncs", leader.getNumPendingSyncs());
- print("last_proposal_size",
leader.getProposalStats().getLastProposalSize());
- print("max_proposal_size",
leader.getProposalStats().getMaxProposalSize());
- print("min_proposal_size",
leader.getProposalStats().getMinProposalSize());
+ print("last_proposal_size",
leader.getProposalStats().getLast());
--- End diff --
One more observation. It seems "ProposalStats" is reused for
clientResponseStats metrics, but it may create confusions due to the method
name mismatches. Again, ProposalStats javadocs says "Provides live statistics
about a running Leader." Also, stats will evolve and could be chance of adding
unrelated metrics later.
How about create a new class "ResponseStats" and name metrics like below.
If we look at the existing min_proposal_size metrics, they didn't use the term
leader/quorum. Keeping that in mind, do we need specifically ''client'' term in
the metrics, simply response gives a context to the users that server-to-client
response. Whats your opinion?
```
last_response_size,
max_response_size,
min_response_size
```
---
